Skip to content

fix(elements): Update supported factors based on status#3843

Merged
alexcarpenter merged 5 commits intomainfrom
alexcarpenter/sdki-294-choose-strategy-step-returning-incorrect-supportedstrategy
Jul 30, 2024
Merged

fix(elements): Update supported factors based on status#3843
alexcarpenter merged 5 commits intomainfrom
alexcarpenter/sdki-294-choose-strategy-step-returning-incorrect-supportedstrategy

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jul 30, 2024

Description

Ensure correct supported strategies are rendered based on first or second factor needs.

https://linear.app/clerk/issue/SDKI-294/choose-strategy-step-returning-incorrect-supportedstrategy-for-second

BEFORE:
Screenshot 2024-07-30 at 4 02 37 PM

AFTER:
Screenshot 2024-07-30 at 4 02 17 PM

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: 8907598

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter merged commit 8d75cb8 into main Jul 30, 2024
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdki-294-choose-strategy-step-returning-incorrect-supportedstrategy branch July 30, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants